Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launch.json .NET folder 3.1 -> 5.0. #1245

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 8, 2021

Like #391, but for debugging after the switch to .NET 5.0 (#1198).


This change is Reviewable

@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label Jul 8, 2021
@imnasnainaec imnasnainaec self-assigned this Jul 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #1245 (3b6bcc3) into master (e4716cf) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   45.36%   45.23%   -0.13%     
==========================================
  Files         266      266              
  Lines        8137     8137              
  Branches      531      531              
==========================================
- Hits         3691     3681      -10     
- Misses       4027     4037      +10     
  Partials      419      419              
Flag Coverage Δ
backend 58.37% <ø> (-0.26%) ⬇️
frontend 33.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Helper/DuplicateFinder.cs 85.80% <0.00%> (-6.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4716cf...3b6bcc3. Read the comment docs.

Copy link
Contributor

@WeJamUS WeJamUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit f755f79 into master Jul 8, 2021
@imnasnainaec imnasnainaec deleted the launch-json-net5 branch July 8, 2021 21:35
@johnthagen
Copy link
Collaborator

@imnasnainaec Sorry I missed this one. Since I wasn't using VSCode, I didn't realize this was needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants