Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate router components #2975

Merged
merged 10 commits into from
Apr 3, 2024
Merged

Consolidate router components #2975

merged 10 commits into from
Apr 3, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 28, 2024

Brings two related components into a common folder. Decreases number of loose items in the src/ folder, which are a hinderance to switching over to Parcel.

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue labels Feb 28, 2024
@imnasnainaec imnasnainaec self-assigned this Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (14d29bc) to head (c24512d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2975   +/-   ##
=======================================
  Coverage   82.92%   82.92%           
=======================================
  Files          47       47           
  Lines        4956     4956           
  Branches      583      583           
=======================================
  Hits         4110     4110           
  Misses        702      702           
  Partials      144      144           
Flag Coverage Δ
backend 82.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested a review from jmgrady March 28, 2024 13:08
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 14 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/router/browserRouter.tsx line 6 at r2 (raw file):

import { store } from "store";
import { changePage } from "types/Redux/analytics";
import { Path } from "types/path";

Should Path also be in the router folder rather than types?

Code quote:

import { Path } from "types/path";

@imnasnainaec imnasnainaec enabled auto-merge (squash) April 3, 2024 16:07
@imnasnainaec imnasnainaec merged commit dda8438 into master Apr 3, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the router branch April 3, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants