-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate router components #2975
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2975 +/- ##
=======================================
Coverage 82.92% 82.92%
=======================================
Files 47 47
Lines 4956 4956
Branches 583 583
=======================================
Hits 4110 4110
Misses 702 702
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 14 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/router/browserRouter.tsx
line 6 at r2 (raw file):
import { store } from "store"; import { changePage } from "types/Redux/analytics"; import { Path } from "types/path";
Should Path
also be in the router
folder rather than types
?
Code quote:
import { Path } from "types/path";
Brings two related components into a common folder. Decreases number of loose items in the
src/
folder, which are a hinderance to switching over to Parcel.This change is