-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate root Redux elements #3054
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3054 +/- ##
==========================================
+ Coverage 74.98% 75.02% +0.03%
==========================================
Files 271 273 +2
Lines 10394 10397 +3
Branches 1230 1230
==========================================
+ Hits 7794 7800 +6
+ Misses 2240 2238 -2
+ Partials 360 359 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 60 of 108 files at r1, 49 of 49 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
-- commits
line 2 at r2:
I will comment here since this is a global comment and hopefully, if you agree, can be done with a simple project-wide find and replace.
I like the reorganization but I find the new filenames repetitive and lengthy. Since the folder is named rootRedux
, root
and rootRedux
can be removed from the filenames. This also makes it more consistent with the hooks.ts
and store.ts
files.
That is:
Replace | With |
---|---|
rootRedux/rootActions.ts | rootRedux/actions.ts |
rootRedux/rootReducer.ts | rootRedux/reducer.ts |
rootRedux/rootReduxTypes.ts | rootRedux/types.ts |
Code quote:
Consolidate root Redux elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 74 of 74 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This change is