Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate root Redux elements #3054

Merged
merged 14 commits into from
Jun 12, 2024
Merged

Consolidate root Redux elements #3054

merged 14 commits into from
Jun 12, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 10, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: M Medium sized issue labels Apr 10, 2024
@imnasnainaec imnasnainaec self-assigned this Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.02%. Comparing base (b75ccd0) to head (00366f9).

Files Patch % Lines
src/rootRedux/types.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3054      +/-   ##
==========================================
+ Coverage   74.98%   75.02%   +0.03%     
==========================================
  Files         271      273       +2     
  Lines       10394    10397       +3     
  Branches     1230     1230              
==========================================
+ Hits         7794     7800       +6     
+ Misses       2240     2238       -2     
+ Partials      360      359       -1     
Flag Coverage Δ
backend 84.04% <ø> (+0.08%) ⬆️
frontend 66.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 60 of 108 files at r1, 49 of 49 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)


-- commits line 2 at r2:
I will comment here since this is a global comment and hopefully, if you agree, can be done with a simple project-wide find and replace.

I like the reorganization but I find the new filenames repetitive and lengthy. Since the folder is named rootRedux, root and rootRedux can be removed from the filenames. This also makes it more consistent with the hooks.ts and store.ts files.
That is:

Replace With
rootRedux/rootActions.ts rootRedux/actions.ts
rootRedux/rootReducer.ts rootRedux/reducer.ts
rootRedux/rootReduxTypes.ts rootRedux/types.ts

Code quote:

Consolidate root Redux elements

@imnasnainaec imnasnainaec requested a review from jmgrady June 12, 2024 11:51
Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 74 of 74 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 8ca63d9 into master Jun 12, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the root-redux branch June 12, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. Size: M Medium sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants