Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run npm update #3179

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Run npm update #3179

merged 6 commits into from
Jun 28, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jun 26, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added frontend dependencies Pull requests that update a dependency file labels Jun 26, 2024
@imnasnainaec imnasnainaec self-assigned this Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.17%. Comparing base (551bfe7) to head (2d39a5e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3179      +/-   ##
==========================================
+ Coverage   75.12%   75.17%   +0.04%     
==========================================
  Files         275      275              
  Lines       10431    10431              
  Branches     1237     1237              
==========================================
+ Hits         7836     7841       +5     
+ Misses       2236     2232       -4     
+ Partials      359      358       -1     
Flag Coverage Δ
backend 84.24% <ø> (+0.10%) ⬆️
frontend 67.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonleenaylor
Copy link
Contributor

src/components/TreeView/TreeDepiction/tests/__snapshots__/index.test.tsx.snap line 4156 at r2 (raw file):

      >
        <button
          className="MuiButtonBase-root MuiButton-root MuiButton-outlined MuiButton-outlinedPrimary MuiButton-sizeMedium MuiButton-outlinedSizeMedium MuiButton-colorPrimary MuiButton-root MuiButton-outlined MuiButton-outlinedPrimary MuiButton-sizeMedium MuiButton-outlinedSizeMedium MuiButton-colorPrimary css-1rwt2y5-MuiButtonBase-root-MuiButton-root"

Just verifying that these test snapshots don't actually indicate an unexpected color change

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec
Copy link
Collaborator Author

Reviewed 19 of 19 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Affirmative. Just did a side-by-side visual check to be sure.

@imnasnainaec imnasnainaec merged commit 565a7f7 into master Jun 28, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the npm-update branch June 28, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants