-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated Hidden component with useMediaQuery hook #3246
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3246 +/- ##
==========================================
- Coverage 74.71% 74.70% -0.02%
==========================================
Files 280 280
Lines 10838 10856 +18
Branches 1314 1317 +3
==========================================
+ Hits 8098 8110 +12
- Misses 2370 2374 +4
- Partials 370 372 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 22 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
src/components/AppBar/ProjectButtons.tsx
line 51 at r2 (raw file):
const navigate = useNavigate(); const isMdUp = useMediaQuery<Theme>((t) => t.breakpoints.up("md"));
These 't' are so close to the useTranslation 't' visually that I glitched. Should we change it? I don't know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 13 of 23 files reviewed, all discussions resolved (waiting on @jasonleenaylor)
src/components/AppBar/ProjectButtons.tsx
line 51 at r2 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
These 't' are so close to the useTranslation 't' visually that I glitched. Should we change it? I don't know.
How about th
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #3220
The following pages/components have layout changes at various window widths. A review of this pr confirms that the changes are visually the same in this branch and on QA.
Transitions can occur at 600px, 900px, 1200px, 1536px window widths.
This change is