Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @testing-library on AppBar, IconButtonWithTooltip, WordCard #3328

Merged
merged 19 commits into from
Feb 12, 2025

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 26, 2024

This change is Reviewable

@imnasnainaec imnasnainaec added test maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Aug 26, 2024
@imnasnainaec imnasnainaec self-assigned this Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.38%. Comparing base (5dfb1a1) to head (8828401).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3328      +/-   ##
==========================================
+ Coverage   74.35%   74.38%   +0.02%     
==========================================
  Files         285      285              
  Lines       11049    11057       +8     
  Branches     1350     1350              
==========================================
+ Hits         8216     8225       +9     
  Misses       2445     2445              
+ Partials      388      387       -1     
Flag Coverage Δ
backend 83.72% <ø> (ø)
frontend 66.18% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec changed the title Move SenseCard.test.tsx to @testing-library Move WordCard tests to @testing-library Aug 28, 2024
@imnasnainaec imnasnainaec changed the title Move WordCard tests to @testing-library Move AppBar & WordCard tests to @testing-library Aug 28, 2024
@imnasnainaec imnasnainaec marked this pull request as ready for review January 28, 2025 16:42
@imnasnainaec imnasnainaec changed the title Move AppBar & WordCard tests to @testing-library Use @testing-library on AppBar, IconButtonWithTooltip, WordCard Jan 28, 2025
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 18 files at r1, 14 of 14 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) February 12, 2025 20:13
@imnasnainaec imnasnainaec merged commit e185a5d into master Feb 12, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the word-card-tests branch February 12, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants