Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable analytics based on user consent #3467

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

andracc
Copy link
Collaborator

@andracc andracc commented Dec 4, 2024

Resolves #3410


This change is Reviewable

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 74.47%. Comparing base (5251099) to head (4f8f7c2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
Backend/Otel/OtelKernel.cs 52.17% 0 Missing and 11 partials ⚠️
...c/components/AnalyticsConsent/AnalyticsConsent.tsx 0.00% 9 Missing ⚠️
src/components/App/AppLoggedIn.tsx 0.00% 4 Missing ⚠️
src/components/UserSettings/UserSettings.tsx 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3467      +/-   ##
==========================================
- Coverage   74.65%   74.47%   -0.19%     
==========================================
  Files         285      286       +1     
  Lines       10999    11035      +36     
  Branches     1338     1345       +7     
==========================================
+ Hits         8211     8218       +7     
- Misses       2404     2429      +25     
- Partials      384      388       +4     
Flag Coverage Δ
backend 83.66% <66.66%> (+0.04%) ⬆️
frontend 66.28% <21.05%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[analytics/cookies] Analytics need to be disabled when user hasn't given consent
1 participant