Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bug-causing 'Sem.' Portuguese translation #3494

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 18, 2024

Our tree browsing expects the head domain to have id Sem, so the fact that there was a Portuguese translation Sem. (and not translated in any other language), the TreeView component misbehaves only when it's in Portuguese.


This change is Reviewable

@imnasnainaec imnasnainaec requested a review from andracc December 18, 2024 19:26
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.63%. Comparing base (e6eb771) to head (179877f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
- Coverage   74.67%   74.63%   -0.04%     
==========================================
  Files         285      285              
  Lines       10996    10996              
  Branches     1337     1337              
==========================================
- Hits         8211     8207       -4     
- Misses       2402     2405       +3     
- Partials      383      384       +1     
Flag Coverage Δ
backend 83.54% <ø> (-0.08%) ⬇️
frontend 66.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec requested a review from andracc December 18, 2024 19:41
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit cf6d1eb into master Dec 18, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the pt-sem branch December 18, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants