Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify TreeView search's event handler to preempt material-table's #804

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 6, 2020

Resolves #794


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Nov 6, 2020
@codecov-io
Copy link

Codecov Report

Merging #804 (ae46130) into master (179562b) will increase coverage by 4.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
+ Coverage   51.22%   55.23%   +4.01%     
==========================================
  Files         237       37     -200     
  Lines        6442     3159    -3283     
  Branches      412        0     -412     
==========================================
- Hits         3300     1745    -1555     
+ Misses       2837     1414    -1423     
+ Partials      305        0     -305     
Flag Coverage Δ
backend 55.23% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nents/ProjectSettings/ProjectUsers/ActiveUsers.tsx
...nts/DataEntry/DataEntryTable/NewEntry/NewEntry.tsx
...taEntry/DataEntryTable/RecentEntry/DeleteEntry.tsx
...Switcher/GoalSelectorScroll/GoalSelectorAction.tsx
src/components/PasswordReset/reducer.tsx
...eline/GoalSuggestions/GoalSuggestionsComponent.tsx
src/components/UserSettings/UserSettings.tsx
...components/SiteSettings/UserManagment/UserList.tsx
...witcher/GoalSelectorScroll/GoalSelectorReducer.tsx
...nts/SiteSettings/UserManagment/ConfirmDeletion.tsx
... and 189 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179562b...ae46130. Read the comment docs.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/components/TreeView/TreeViewHeader.tsx, line 58 at r1 (raw file):

event.stopPropagation();

Nice!

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@imnasnainaec imnasnainaec merged commit 6bc16e4 into master Nov 9, 2020
@imnasnainaec imnasnainaec deleted the review-entries-sem-dom-search branch November 9, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domain search doesn't work in Review Entries
3 participants