-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit default formatters by language #808
Conversation
package.json, line 16 at r1 (raw file):
Can this be merged into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
package.json, line 16 at r1 (raw file): Previously, johnthagen wrote…
Specifically, if we want to validate that everything is formatted properly, we'd need to add a |
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
==========================================
+ Coverage 51.17% 51.18% +0.01%
==========================================
Files 237 237
Lines 6449 6449
Branches 416 416
==========================================
+ Hits 3300 3301 +1
Misses 2841 2841
+ Partials 308 307 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @johnthagen)
package.json, line 16 at r1 (raw file):
Previously, johnthagen wrote…
Specifically, if we want to validate that everything is formatted properly, we'd need to add a
fmt-project-check
as well. I'd suggest we just include these extra files infmt-frontend
/fmt-frontend-check
. Basically all of these files are part of thefrontend
project, even though in the Combine we have sorta mashed a lot of projects (including backend) into the top level folder.
It's just a few files, so I think it's simplest to add them in with fmt-frontend[-check]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
A recent VSCode update created a need for formatters to be specified language by language: microsoft/vscode#108447 (comment)
This change is