Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit default formatters by language #808

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 12, 2020

A recent VSCode update created a need for formatters to be specified language by language: microsoft/vscode#108447 (comment)


This change is Reviewable

@imnasnainaec imnasnainaec added the maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. label Nov 12, 2020
@imnasnainaec imnasnainaec self-assigned this Nov 12, 2020
@johnthagen
Copy link
Collaborator


package.json, line 16 at r1 (raw file):

    "fmt-frontend": "prettier --write \"./src/**/*.{js,jsx,ts,tsx,json}\"",
    "fmt-frontend-check": "prettier --check \"./src/**/*.{js,jsx,ts,tsx,json}\"",
    "fmt-project": "prettier --write \"./{.vscode,public,scripts}/**/*.{js,jsx,ts,tsx,json}\"",

Can this be merged into fmt-frontend since it's mostly a duplication? I see the distinction, perhaps we should call it fmt-js for (format JavaScript family? including JS, TS, JSON)?

Copy link
Collaborator

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)

@johnthagen
Copy link
Collaborator


package.json, line 16 at r1 (raw file):

Previously, johnthagen wrote…

Can this be merged into fmt-frontend since it's mostly a duplication? I see the distinction, perhaps we should call it fmt-js for (format JavaScript family? including JS, TS, JSON)?

Specifically, if we want to validate that everything is formatted properly, we'd need to add a fmt-project-check as well. I'd suggest we just include these extra files in fmt-frontend / fmt-frontend-check. Basically all of these files are part of the frontend project, even though in the Combine we have sorta mashed a lot of projects (including backend) into the top level folder.

@codecov-io
Copy link

codecov-io commented Nov 13, 2020

Codecov Report

Merging #808 (60f584c) into master (0e34593) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #808      +/-   ##
==========================================
+ Coverage   51.17%   51.18%   +0.01%     
==========================================
  Files         237      237              
  Lines        6449     6449              
  Branches      416      416              
==========================================
+ Hits         3300     3301       +1     
  Misses       2841     2841              
+ Partials      308      307       -1     
Flag Coverage Δ
backend 55.23% <ø> (ø)
frontend 47.29% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utilities.tsx 85.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e34593...60f584c. Read the comment docs.

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @johnthagen)


package.json, line 16 at r1 (raw file):

Previously, johnthagen wrote…

Specifically, if we want to validate that everything is formatted properly, we'd need to add a fmt-project-check as well. I'd suggest we just include these extra files in fmt-frontend / fmt-frontend-check. Basically all of these files are part of the frontend project, even though in the Combine we have sorta mashed a lot of projects (including backend) into the top level folder.

It's just a few files, so I think it's simplest to add them in with fmt-frontend[-check].

Copy link
Collaborator

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@imnasnainaec imnasnainaec merged commit 5c1a0f2 into master Nov 13, 2020
@imnasnainaec imnasnainaec deleted the vscode-formatting branch November 13, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants