Set cache expiration for frontend route #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
=======================================
Coverage 51.17% 51.17%
=======================================
Files 237 237
Lines 6449 6449
Branches 416 416
=======================================
Hits 3300 3300
Misses 2841 2841
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jasonleenaylor
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
jmgrady
approved these changes
Nov 13, 2020
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set cache expiration to 12 hours on the frontend routes so that if the server's frontend implementation is updated, clients will automatically pull in a fresh version at the beginning of the next day.
This fixes the issue where users have to manually refresh to update their cached frontend implementation.
This change is