-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add liftImported field to existing projects #815
Conversation
New script to add liftImported field to documents in ProjectsCollection. Field is set to true if a Compressed Upload ZIP file exists for the project; false otherwise.
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
==========================================
+ Coverage 51.03% 55.22% +4.19%
==========================================
Files 239 37 -202
Lines 6480 3158 -3322
Branches 420 0 -420
==========================================
- Hits 3307 1744 -1563
+ Misses 2863 1414 -1449
+ Partials 310 0 -310
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other ways that we might be able to tell that data have been imported?
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jmgrady)
@jmgrady A file of the form |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the script to look for this instead of the .zip file.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jmgrady)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
* Upload Lift files to the temp directory before extraction * Extract GetRandomTempDir function * Add Project.LiftImported to track if a Lift file has already been imported (will require use of #815 on server upon release) * Update frontend project to match backend Project * Simplify directory and zip management * Allow Lift files to be imported after audio is uploaded (#788)
New script to add liftImported field to documents in ProjectsCollection.
Updates the
CombineDatabase
for changes to the ProjectsCollection structure that is added with PR #810.Field is set to true if a Compressed Upload ZIP file exists for the
project; false otherwise.
This change is