Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liftImported field to existing projects #815

Merged
merged 5 commits into from
Nov 17, 2020
Merged

Conversation

jmgrady
Copy link
Collaborator

@jmgrady jmgrady commented Nov 15, 2020

New script to add liftImported field to documents in ProjectsCollection.

Updates the CombineDatabase for changes to the ProjectsCollection structure that is added with PR #810.

Field is set to true if a Compressed Upload ZIP file exists for the
project; false otherwise.


This change is Reviewable

New script to add liftImported field to documents in ProjectsCollection. 
 Field is set to true if a Compressed Upload ZIP file exists for the 
project; false otherwise.
@jmgrady jmgrady added deployment maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Nov 15, 2020
@jmgrady jmgrady self-assigned this Nov 15, 2020
@codecov-io
Copy link

codecov-io commented Nov 15, 2020

Codecov Report

Merging #815 (af6e7e9) into master (d1cd125) will increase coverage by 4.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   51.03%   55.22%   +4.19%     
==========================================
  Files         239       37     -202     
  Lines        6480     3158    -3322     
  Branches      420        0     -420     
==========================================
- Hits         3307     1744    -1563     
+ Misses       2863     1414    -1449     
+ Partials      310        0     -310     
Flag Coverage Δ
backend 55.22% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...iesComponent/CellComponents/PronunciationsCell.tsx
...yTable/EntryCellComponents/VernWithSuggestions.tsx
.../ReviewEntriesComponent/ReviewEntriesComponent.tsx
src/components/GoalTimeline/GoalSwitcher/index.tsx
...ents/DataEntry/DataEntryHeader/DataEntryHeader.tsx
.../DataEntry/DataEntryTable/NewEntry/SenseDialog.tsx
...nents/ProjectSettings/ProjectUsers/ActiveUsers.tsx
src/components/GoalTimeline/GoalsActions.tsx
src/components/App/component.tsx
src/types/project.tsx
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1cd125...af6e7e9. Read the comment docs.

@imnasnainaec
Copy link
Collaborator

This won't be able to identify projects with lift files imported after Nov 2 (#791), so #810 would allow some recent projects to import a second lift file.

Copy link
Collaborator Author

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other ways that we might be able to tell that data have been imported?

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jmgrady)

@imnasnainaec
Copy link
Collaborator

Are there any other ways that we might be able to tell that data have been imported?

@jmgrady A file of the form [projectId]/Import/ExtractedLocation/Lift/*.lift should persist even if the zip that was imported has been deleted. That folder structure is created if audio is added in the project, but the .lift file is only present if there was a Lift import.

Copy link
Collaborator Author

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the script to look for this instead of the .zip file.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @jmgrady)

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@jmgrady jmgrady merged commit 4bfc0ed into master Nov 17, 2020
@jmgrady jmgrady deleted the lift_imported_field branch November 17, 2020 21:45
imnasnainaec pushed a commit that referenced this pull request Nov 17, 2020
* Upload Lift files to the temp directory before extraction
* Extract GetRandomTempDir function
* Add Project.LiftImported to track if a Lift file has already been imported (will require use of #815 on server upon release)
* Update frontend project to match backend Project
* Simplify directory and zip management
* Allow Lift files to be imported after audio is uploaded (#788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants