Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate /users #1043

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Paginate /users #1043

merged 7 commits into from
Nov 18, 2024

Conversation

FyreByrd
Copy link

Added server-side pagination and search to /users.
Also handled locking and unlocking of users. I have no idea how this is used in S1, but we can figure that out later, for now I have just implemented the ability to mark a user as locked or unlocked in the database. I also added code to prevent a user from being able to lock themself by disabling the toggle in the client and running a sanity check in the server.

I am willing to consider adding a few more features before merging, if those features would be best added here.
Features I would consider:

  • Handling permissions for locked users.
  • Sorting (this may entail rebasing and using feature/svelte-headless-table
  • Searching over more than just user name and email
  • Improving data display on mobile

Here is a screenshot of what the page looks like now. Primary difference is adding the toggle for locking/unlocking.

image

Here is mobile. I am not a big fan of how the data is displayed for mobile, but I am unsure how to improve it.

image

@FyreByrd FyreByrd merged commit 45a94f5 into feature/svelte Nov 18, 2024
2 checks passed
@FyreByrd FyreByrd deleted the feature/paginate-users branch November 18, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants