-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paginate /product/[id]/files #1051
Conversation
@FyreByrd Please resolve merge conflicts. If we want to add pagination to builds, we can have fewer builds per page (like 2 or 3) since most people only care about the most recent. |
6df8664
to
16d6e34
Compare
Resolved merge conflicts |
@FyreByrd We will need to manually format that label until i18n supports pluralization. |
@FyreByrd I notices that when it scrolls, it cuts off the border on the right: |
@FyreByrd What problem are you trying to solve with the pagination of product files? Does it reduce that data transmitted and help performance of the page? |
It probably doesn't need to be paginated? It won't send a ton of data unless a product has a lot of builds.
You also asked to show only 2 or 3 per page. |
But yes, that is roughly the goal of pagination. I don't really have enough test data to see what performance gains there would be. |
UX issues:
|
I am currently working on these issues. Thank you for bringing 2. to my attention. |
df2eb2f
to
2289159
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Added server-side pagination and improved the overall UI of
/product/[id]/files
Notes:
Desktop:
Mobile: