Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate /product/[id]/files #1051

Merged
merged 15 commits into from
Dec 12, 2024
Merged

Conversation

FyreByrd
Copy link

@FyreByrd FyreByrd commented Nov 22, 2024

Added server-side pagination and improved the overall UI of /product/[id]/files

Notes:

  • The i18n library we have been using currently does not support pluralization, so some of the UI is still a bit rough around the edges.
  • The page will show 3 builds per pagination by default
  • On mobile, the tabular list of the product files is horizontally scrollable, and the name of the file is kept visible

Desktop:

image

Mobile:

image

@chrisvire
Copy link
Member

@FyreByrd Please resolve merge conflicts.

If we want to add pagination to builds, we can have fewer builds per page (like 2 or 3) since most people only care about the most recent.

@FyreByrd FyreByrd force-pushed the feature/paginate-product-files branch from 6df8664 to 16d6e34 Compare December 2, 2024 14:12
@FyreByrd
Copy link
Author

FyreByrd commented Dec 2, 2024

Resolved merge conflicts

@chrisvire
Copy link
Member

@FyreByrd We will need to manually format that label until i18n supports pluralization.

@chrisvire
Copy link
Member

@FyreByrd I notices that when it scrolls, it cuts off the border on the right:

image

@chrisvire
Copy link
Member

@FyreByrd What problem are you trying to solve with the pagination of product files? Does it reduce that data transmitted and help performance of the page?

@FyreByrd
Copy link
Author

FyreByrd commented Dec 4, 2024

@FyreByrd What problem are you trying to solve with the pagination of product files? Does it reduce that data transmitted and help performance of the page?

It probably doesn't need to be paginated? It won't send a ton of data unless a product has a lot of builds.

If we want to add pagination to builds, we can have fewer builds per page (like 2 or 3) since most people only care about the most recent.

You also asked to show only 2 or 3 per page.

@FyreByrd
Copy link
Author

FyreByrd commented Dec 4, 2024

@FyreByrd What problem are you trying to solve with the pagination of product files? Does it reduce that data transmitted and help performance of the page?

But yes, that is roughly the goal of pagination. I don't really have enough test data to see what performance gains there would be.

@chrisvire
Copy link
Member

UX issues:

  1. Clicking anywhere in the header should expand/contract the list of files (if we want to be consistent with S1. Do we need an expanding/contracting list? The original UI was in a popup window and then moved to a route. I didn't want to spend a lot of time reworking the UI in React since I knew we would be rewriting it.
  2. The text color of the selected item is hard to see.

image

  1. If we keep the header, the pluralization needs to be addressed.

@FyreByrd
Copy link
Author

FyreByrd commented Dec 4, 2024

UX issues:

  1. Clicking anywhere in the header should expand/contract the list of files (if we want to be consistent with S1. Do we need an expanding/contracting list? The original UI was in a popup window and then moved to a route. I didn't want to spend a lot of time reworking the UI in React since I knew we would be rewriting it.

  2. The text color of the selected item is hard to see.

  3. If we keep the header, the pluralization needs to be addressed.

I am currently working on these issues. Thank you for bringing 2. to my attention.

@FyreByrd FyreByrd force-pushed the feature/paginate-product-files branch from df2eb2f to 2289159 Compare December 6, 2024 20:55
Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FyreByrd FyreByrd merged commit a6a1f69 into feature/svelte Dec 12, 2024
2 checks passed
@FyreByrd FyreByrd deleted the feature/paginate-product-files branch December 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants