Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create, Import, and Archive/Reactivate Projects #1059

Open
wants to merge 29 commits into
base: feature/svelte
Choose a base branch
from

Conversation

FyreByrd
Copy link

@FyreByrd FyreByrd commented Dec 5, 2024

Added jobs to handle creation of projects in BuildEngine.
Handle Project Imports.
I am not 100% certain what the full expected behavior is for Archival and Reactivation, so we will need to discuss this before merging.

Add Project Page:
image

image

Import Project Page:
image

image

@FyreByrd FyreByrd requested a review from chrisvire December 5, 2024 15:32
@FyreByrd FyreByrd force-pushed the feature/project-jobs branch from b8eaf1d to 40cf8f8 Compare December 6, 2024 20:33
@chrisvire
Copy link
Member

When a project is first created:

image

@FyreByrd
Copy link
Author

When a project is first created:

image

Taken care of

Since this does not mimic S1 behavior, but would be desirable behavior in the future, I am commenting this out for now and instead opening an issue for discussion, per prior conversation on this topic.
@chrisvire
Copy link
Member

Add Project

User Experience issues:

  • I accidentally hit enter when the Save button didn't have focus and the project was created. I was surprised by this. This is not the behavior of S1.
  • In S1, the save button is disabled until all the required fields (Project Name, Language Code ... and I assume Project Group and Type, but they have default values) are filled in.
  • In S2. the only option is "Scripture App Builder" but it should have all the options (in table Application Types)
  • In S2, the fields should stack all vertically if on a narrow device

I noticed on the Add Project page that the breakpoint for switching to a narrow layout is 380px. That is not one of the default breakpoints in Tailwind. Curious about it. The breakpoint in S2 is 640 (sm breakpoint).

Import Project

User Experience issues:

  • In S2. the only option is "Scripture App Builder" but it should have all the options (in table Application Types)
  • I selected a file and clicked save, but nothing happened.

Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User experience issues

@FyreByrd
Copy link
Author

  • In S2. the only option is "Scripture App Builder" but it should have all the options (in table Application Types)

Regarding the available Application Types, I am only presenting the available options based on the OrganizationProductDefinitions table. My assumption was that we wouldn't want for users to create a project that isn't valid for their organization. In the example data for dev, all of the entries in OrganizationProductDefinitions for SIL have product definitions that use the SAB Application Type, hence SAB is the only option that will be visible.

@FyreByrd
Copy link
Author

  • In S2. the only option is "Scripture App Builder" but it should have all the options (in table Application Types)

Regarding the available Application Types, I am only presenting the available options based on the OrganizationProductDefinitions table. My assumption was that we wouldn't want for users to create a project that isn't valid for their organization. In the example data for dev, all of the entries in OrganizationProductDefinitions for SIL have product definitions that use the SAB Application Type, hence SAB is the only option that will be visible.

This is incorrect behavior and has been updated to show all application types

@FyreByrd
Copy link
Author

  • I accidentally hit enter when the Save button didn't have focus and the project was created. I was surprised by this. This is not the behavior of S1.

I have resolved all the issues except this one. As best as I can tell, this is the default behavior of the browser. This would likely need to be fixed in multiple location, not just the add project form.
For now, I think the issue has been partially mitigated by blocking form submission unless the name and language code are both set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants