Add Jobs for Product Creation, Builds, and Publishing #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few things I am not certain on.
I am also experiencing some weird bugs with BuildEngine right now. For these reasons, this is currently a draft PR. |
|
One other thing that should be resolved first: What does the expired status mean and how should it be handled? |
Fix product validation
- Tighten typing of environment - Create bullmq job to get versionCode for GOOGLE_PLAY_UPLOADED, because XState won't properly handle asynchronous actions (ugh)
why was this async in the first place??? yes, it was my fault, but still, why???
The activityName was sometimes showing up blank. After investigating further, I was able to narrow it down to existing just at the start of a new product. This issue was sometimes persisting when the jobs backend was incorrect.
Had been deleting previous artifacts based on logic from S1 backend. This was determined to be unneeded, as the relevant code in S1 was determined to be unreachable after talking with @chrisvire
FyreByrd
force-pushed
the
feature/product-jobs
branch
from
27eb419 to
44c04b5
Compare
|
I resolved the BuildEngine issue, so this should be ready for review/requests |
S1 has a close X in the top right. |
Added |
Switch updateProjectDateActive back to expected functionality based on S1. I still don't fully understand under which conditions we would want to be running this. Right now I just have it to where it will execute each time a product is created, updated, or deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the creation of a Product in BuildEngine, as well as the Build and Release processes in BuildEngine.
Properly handles the creation of ProductArtifacts in the database.
Also added UI for creating a Product.