Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ask Bing translator to translate language names #66

Closed
tombogle opened this issue Jul 5, 2019 · 1 comment
Closed

Don't ask Bing translator to translate language names #66

tombogle opened this issue Jul 5, 2019 · 1 comment
Assignees
@tombogle
Labels
bug

Comments

@tombogle
Copy link
Contributor

tombogle commented Jul 5, 2019

In LanguageChoosingDialog.Application_Idle, it uses a BingTranslator to try to localize the apology message. Unfortunately, given the string:
Our apologies, this program has not yet been localized for German (Deutsch). Please choose from one of the following languages:
Bing translates Deutsch as English. The string submitted to Bing should be the original format string, rather than the string with the parameters substituted in.
@tombogle tombogle self-assigned this Jul 5, 2019
@tombogle tombogle added the bug label Jul 5, 2019
tombogle added a commit that referenced this issue Jul 5, 2019
@tombogle
Fix for #66
71d4749
@tombogle tombogle mentioned this issue Jul 5, 2019
Merged
@tombogle
Copy link
Contributor Author

tombogle commented Jul 8, 2019

#67

@tombogle tombogle closed this as completed Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombogle tombogle

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tombogle