Fix hgweb race condition in GetLastCommitTime #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a project has just been created and then a zip file uploaded to populate it with initial data, as happens often in integration tests, then hgweb could return 404 for /hg/projectCode/log because its internal list of repos was recently refreshed (by another test) and the refresh interval hasn't been reached yet. One way to avoid this is to use the command runner to get the last commit date, since the hg command line doesn't use the refreshinterval setting from hgweb.
C# Unit Tests66 tests 66 ✅ 5s ⏱️ Results for commit 31bed3b. ♻️ This comment has been updated with latest results. |
hahn-kev
requested changes
Aug 14, 2024
Also expand the range of unit tests to include all kinds of invalid values, making sure ConvertHgDate returns null for all invalid data.
hahn-kev
previously approved these changes
Aug 16, 2024
We'll change this to upload build artifacts for the different container logs, but this will get the error messages more quickly for now.
kubectl logs defaults to `--tail=10` if you pass a pod selector, so we have to explicitly request `--tail=-1` to get *all* log lines.
|
Failing integration tests are caused by the |
hahn-kev
approved these changes
Aug 20, 2024
|
Closing and reopening to get CodeQL to do its job, sigh... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a project has just been created and then a zip file uploaded to populate it with initial data, as happens often in integration tests, then hgweb could return 404 for /hg/projectCode/log because its internal list of repos was recently refreshed (by another test) and the refresh interval hasn't been reached yet. One way to avoid this is to use the command runner to get the last commit date, since the hg command line doesn't use the refreshinterval setting from hgweb.
Fixes #1025.