rework auth to use a list of servers #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…take you home after you load a project
…points, this means the local list will load faster and not wait for a timeout if the user is offline
C# Unit Tests66 tests 66 ✅ 5s ⏱️ Results for commit f08ad6e. ♻️ This comment has been updated with latest results. |
# Conflicts: # backend/FwLite/LocalWebApp/LocalWebApp.csproj # backend/FwLite/LocalWebApp/Services/LexboxProjectService.cs
rmunn
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new home page
As you can see there's now a list of servers to login to, this list is defined as a configuration value, so devs can add whatever servers they want, by default users will use lexbox.org, but they could override that if they wanted (todo on how exactly to implement that). Each of those servers we fetch a list of CRDT projects from, we then match that with the local project list (for now it's just name based, but we can match on project Id in the future).
The big question is how to handle uploading new projects. Previously there was just one button and it would upload to the one server. Should we instead have the upload handled on the project page? then the user can pick the server to upload (unless there's only 1). The question then is how to handle creating that project server side. Should we do it for the user? should we only allow uploading to an empty project?