Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle entry sorting in mongo #772

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

hahn-kev
Copy link
Collaborator

closes #771

you can't select in a sort aggreigate, so that's why I needed to select a new field first in order to sort by it.

@hahn-kev hahn-kev requested a review from myieye April 30, 2024 23:55
Copy link

github-actions bot commented Apr 30, 2024

C# Unit Tests

36 tests  ±0   36 ✅ ±0   4s ⏱️ ±0s
 8 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b37299f. ± Comparison against base commit 8101256.

♻️ This comment has been updated with latest results.

@megahirt
Copy link
Contributor

megahirt commented May 2, 2024

See #771 (comment)

I feel like this is a good intermediate solution to the performance problems, however users will want to be able to sort their minority language correctly using customized rules, and I don't believe we can teach the database to sort based on custom rules. So the ultimate implementation will need to be done either client side (load all data) or server side (memory intensive)

Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if you're expecting me to verify that everything is happening in the DB (I didn't :/), but it looks great. 😀

backend/LfClassicData/LfClassicLexboxApi.cs Outdated Show resolved Hide resolved
Co-authored-by: Tim Haasdyk <myieye@gmail.com>
@hahn-kev hahn-kev merged commit 3e12b8a into develop May 6, 2024
5 checks passed
@hahn-kev hahn-kev deleted the bug/order-entries-in-mongo branch July 9, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

querying a large project with the lf classic api can use too much memory
3 participants