Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup syncing between fwdata and crdts #991

Merged
merged 16 commits into from
Aug 20, 2024
Merged

Conversation

hahn-kev
Copy link
Collaborator

Still a PoC, not sure where this code will end up, but I wanted to get started on something.

  • update harmony repo, renames Crdt to SIL.Harmony
  • write tests for Crdt Entity copy methods.
  • add sync update tests with generated dummy data to ensure that no fields are missed, especially when adding new fields. write multiString diff tests
  • enable creating new fwdata projects
  • add support for creating writing systems
  • make default fwdata project path configurable

* write tests for Crdt Entity copy methods.
* add sync update tests with generated dummy data to ensure that no fields are missed, especially when adding new fields.
write multiString diff tests
* enable creating new fwdata projects
* add support for creating writing systems
* make default fwdata project path configurable
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but once they're addressed this LGTM and I'll approve it.

# Conflicts:
#	backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs
#	backend/FwLite/FwDataMiniLcmBridge/FieldWorksProjectList.cs
#	backend/FwLite/FwDataMiniLcmBridge/LcmUtils/ProjectLoader.cs
rmunn
rmunn previously approved these changes Aug 14, 2024
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One VERY minor change needed (creating Templates folder if it doesn't exist), but mostly this is good to go. So I'm approving it even without that change.

…ollow. Implement creating semantic domains and part of speech.

Refactor sync tests to use in memory LCM provided by the bridge tests.
Copy link

C# Unit Tests

54 tests   54 ✅  5s ⏱️
11 suites   0 💤
 1 files     0 ❌

Results for commit 32d9135.

@hahn-kev hahn-kev merged commit 7c22069 into develop Aug 20, 2024
13 checks passed
@hahn-kev hahn-kev deleted the feat/sync-fwdata-with-crdt branch August 20, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants