Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test on Ubuntu 18.04 #888

Merged
merged 3 commits into from
Jan 17, 2020
Merged

Fix unit test on Ubuntu 18.04 #888

merged 3 commits into from
Jan 17, 2020

Conversation

ermshiperete
Copy link
Member

@ermshiperete ermshiperete commented Jan 17, 2020

Also some refactorings and a comment about a failing test that requires some production code changes to fix (cf #887).


This change is Reviewable

Ubuntu 18.04 changed the name of a keyboard layout. This change
allows the test run on Bionic as well as the older Ubuntu versions.
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ermshiperete ermshiperete merged commit c03761a into sillsdev:master Jan 17, 2020
@ermshiperete ermshiperete deleted the feature/fixUnitTest branch January 17, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants