-
-
Notifications
You must be signed in to change notification settings - Fork 3
Update machine library to 1.6.3 #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=======================================
Coverage 88.87% 88.87%
=======================================
Files 282 282
Lines 16951 16951
=======================================
Hits 15065 15065
Misses 1886 1886 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)
pyproject.toml line 35 at r1 (raw file):
[tool.poetry] name = "sil-machine" version = "1.6.3"
It feels like there are enough changes to warrant a minor version bump, i.e. 1.7.0.
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ddaspit)
pyproject.toml line 35 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
It feels like there are enough changes to warrant a minor version bump, i.e.
1.7.0.
Done. Except now the branch name is killing me 😆 😵💫
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
pyproject.toml line 35 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Done. Except now the branch name is killing me 😆 😵💫
I know it's hard, but you'll survive. 🤣
This change is