Skip to content

Add TryParse to ScriptureRef #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enkidu93 merged 3 commits into from
Nov 13, 2025
Merged

Add TryParse to ScriptureRef #357

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
918014c
Add TryParse to ScriptureRef
Enkidu93 Nov 13, 2025
16d3369
Reviewer comments
Enkidu93 Nov 13, 2025
a92ae26
Reuse method in overload
Enkidu93 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/SIL.Machine/Corpora/ScriptureRef.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,25 @@ public static ScriptureRef Parse(string str, ScrVers versification = null)
return new ScriptureRef(new VerseRef(vref, versification ?? ScrVers.English), path);
}

public static bool TryParse(string str, out ScriptureRef scriptureRef)
{
return TryParse(str, null, out scriptureRef);
}

public static bool TryParse(string str, ScrVers versification, out ScriptureRef scriptureRef)
{
try
{
scriptureRef = Parse(str, versification);
return true;
}
catch (VerseRefException)
{
scriptureRef = Empty;
return false;
}
}

public ScriptureRef(VerseRef verseRef = default, IEnumerable<ScriptureElement> path = null)
{
VerseRef = verseRef;
Expand Down
Loading