Skip to content

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Nov 13, 2025

Partially fixes #796. Still waiting on direction for a proper solution in libpalaso.


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit November 13, 2025 18:24
@Enkidu93 Enkidu93 force-pushed the do_not_crash_on_invalid_verse_refs branch from 99f2bb2 to 0be53e2 Compare November 13, 2025 18:26
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.21%. Comparing base (3a24d39) to head (e85ac1d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
- Coverage   66.21%   66.21%   -0.01%     
==========================================
  Files         379      379              
  Lines       20356    20361       +5     
  Branches     2650     2652       +2     
==========================================
+ Hits        13479    13482       +3     
  Misses       5932     5932              
- Partials      945      947       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddaspit reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)


src/Serval/src/Serval.Translation/Services/PretranslationService.cs line 147 at r1 (raw file):

                            try
                            {
                                return ScriptureRef.Parse(r, targetSettings.Versification);

Can you add a ScriptureRef.TryParse method that returns a boolean and has a ScriptureRef out parameter?

Copy link
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)


src/Serval/src/Serval.Translation/Services/PretranslationService.cs line 147 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

Can you add a ScriptureRef.TryParse method that returns a boolean and has a ScriptureRef out parameter?

I can! That'll require a machine PR of course. I'll go ahead and put that in.

Copy link
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @ddaspit)


src/Serval/src/Serval.Translation/Services/PretranslationService.cs line 147 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

I can! That'll require a machine PR of course. I'll go ahead and put that in.

Done.

@Enkidu93 Enkidu93 requested a review from ddaspit November 14, 2025 16:22
Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 merged commit 129467e into main Nov 14, 2025
3 checks passed
@Enkidu93 Enkidu93 deleted the do_not_crash_on_invalid_verse_refs branch November 14, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VerseRef parsing error

4 participants