-
-
Notifications
You must be signed in to change notification settings - Fork 2
Do not crash when pretranslations have invalid verse references #827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
99f2bb2 to
0be53e2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #827 +/- ##
==========================================
- Coverage 66.21% 66.21% -0.01%
==========================================
Files 379 379
Lines 20356 20361 +5
Branches 2650 2652 +2
==========================================
+ Hits 13479 13482 +3
Misses 5932 5932
- Partials 945 947 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)
src/Serval/src/Serval.Translation/Services/PretranslationService.cs line 147 at r1 (raw file):
try { return ScriptureRef.Parse(r, targetSettings.Versification);
Can you add a ScriptureRef.TryParse method that returns a boolean and has a ScriptureRef out parameter?
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)
src/Serval/src/Serval.Translation/Services/PretranslationService.cs line 147 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Can you add a
ScriptureRef.TryParsemethod that returns a boolean and has aScriptureRefout parameter?
I can! That'll require a machine PR of course. I'll go ahead and put that in.
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @ddaspit)
src/Serval/src/Serval.Translation/Services/PretranslationService.cs line 147 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
I can! That'll require a machine PR of course. I'll go ahead and put that in.
Done.
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 4 of 4 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
Partially fixes #796. Still waiting on direction for a proper solution in libpalaso.
This change is