Skip to content

Conversation

@benjaminking
Copy link
Collaborator

@benjaminking benjaminking commented Dec 15, 2025

This PR addresses #852 about creating a more user-friendly remark for quotation denormalization. The following changes were made:

  • There is a now a separate remark to be used when all chapters were successfully denormalized
  • If some chapters were denormalized and others weren't, the remark will contain lists of denormalized and non-denormalized chapters
  • The lists of chapters use ranges, e.g. 1-5
  • When there are two or more items to list, the word "and" is included for better readability.

This change is Reviewable

Copy link
Collaborator

@TaperChipmunk32 TaperChipmunk32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved

@benjaminking benjaminking merged commit 34e11ef into master Dec 15, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants