Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run docker scan and triage results into future issues #1117

Closed
megahirt opened this issue Sep 2, 2021 · 2 comments · Fixed by #1154
Closed

run docker scan and triage results into future issues #1117

megahirt opened this issue Sep 2, 2021 · 2 comments · Fixed by #1154
Assignees
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix

Comments

@megahirt
Copy link
Collaborator

megahirt commented Sep 2, 2021

No description provided.

@alex-larkin alex-larkin added the engineering Tasks which do not directly relate to a user-facing feature or fix label Sep 3, 2021
@longrunningprocess
Copy link
Contributor

longrunningprocess commented Sep 7, 2021

ran into an issue building the ui image locally...it's probably related to my new M1, I need to troubleshoot a missing python warning in the build. (probably relevant https://stackoverflow.com/questions/66587927/macbook-m1-node-js-docker-image-build-failed)

@megahirt
Copy link
Collaborator Author

megahirt commented Sep 7, 2021

Per our standup discussion, this is likely due to node-sass not being able to download a binary for the ARM m1 architecture, so it falls back to building with node-gyp, python, etc. Those build tools are missing from our image, which is why the build fails. On x86 node-sass has pre-built binaries that can simply be downloaded, so no build tools are required.

The best way forward is to replace node-sass with sass (Dart Sass) in our development chain, as Dart sass should be architecture independent. I've created #1137 to replace node-sass with sass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Tasks which do not directly relate to a user-facing feature or fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants