Added ability to run security scans of our images #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megahirt
reviewed
Sep 14, 2021
|
FYI I tried to run this locally and got the message
|
I didn't actually install it individually, it must already be part of Docker Desktop for Mac. I suppose you could install it manually if you wanted to run it as well. |
|
tracked report in #1155 |
longrunningprocess
force-pushed
the
issue/1117-security-scan
branch
from
565c0e6
to
ded6051
Compare
in the hopes of not misleading someone running the make scan and seeing error messages, we'll inform make to ignore that result from scan...it returns a `1` if it finds any vulnerabilities and we're already redirecting all that into a "report".
longrunningprocess
force-pushed
the
issue/1117-security-scan
branch
from
ded6051
to
00fca61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We needed to run
docker scanagainst our images to understand current vulnerabilities. These commits will both added some convenience scripts for future use as well as begin to triage the results and plans for mitigation.Fixes #1117
Type of Change
Check all that apply:
Screenshots
N/A
How Has This Been Tested?
Checklist:
developafter Emulate x86 so local dev is possible on arm64 machines #1142 gets merged intodevelop