Skip to content

Clean up realtime docs when they're no longer needed #3199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented May 13, 2025

This is still work in progress, but I want to put it out here as it appears to be working.


This change is Reviewable

@Nateowami Nateowami force-pushed the feature/clean-up-realtime-docs branch 2 times, most recently from abf739b to db6ad5d Compare May 13, 2025 14:36
@Nateowami Nateowami marked this pull request as draft May 13, 2025 14:37
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 75.64103% with 38 lines in your changes missing coverage. Please review.

Project coverage is 83.00%. Comparing base (8fd5875) to head (74cce2c).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...re/ClientApp/src/xforge-common/realtime.service.ts 18.18% 18 Missing ⚠️
...ClientApp/src/xforge-common/models/realtime-doc.ts 61.53% 5 Missing ⚠️
...ientApp/src/app/core/translation-engine.service.ts 0.00% 2 Missing ⚠️
...diagnostic-overlay/diagnostic-overlay.component.ts 0.00% 2 Missing ⚠️
...nslate/editor/note-dialog/note-dialog.component.ts 80.00% 2 Missing ⚠️
...App/src/xforge-common/activated-project.service.ts 33.33% 2 Missing ⚠️
...ientApp/src/xforge-common/user-projects.service.ts 0.00% 2 Missing ⚠️
...pture/ClientApp/src/app/core/sf-project.service.ts 88.88% 1 Missing ⚠️
...anslate/biblical-terms/biblical-terms.component.ts 75.00% 1 Missing ⚠️
...dialog/editor-tab-add-resource-dialog.component.ts 66.66% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3199      +/-   ##
==========================================
- Coverage   83.02%   83.00%   -0.03%     
==========================================
  Files         569      568       -1     
  Lines       33217    33224       +7     
  Branches     5355     5329      -26     
==========================================
- Hits        27577    27576       -1     
- Misses       4848     4854       +6     
- Partials      792      794       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nateowami Nateowami force-pushed the feature/clean-up-realtime-docs branch from db6ad5d to 9fcd8f8 Compare May 13, 2025 15:22
@Nateowami Nateowami force-pushed the feature/clean-up-realtime-docs branch from 9fcd8f8 to 74cce2c Compare May 13, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant