Skip to content

SF-3331b Simplify CSS for multi book selection #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented May 22, 2025

  • Simplifies the CSS a bit
  • Fixes the layout on small screens when deuterocanon is shown
Before After

This change is Reviewable

@Nateowami Nateowami requested a review from josephmyers May 22, 2025 16:32
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.92%. Comparing base (0786458) to head (82e63c8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3214   +/-   ##
=======================================
  Coverage   81.92%   81.92%           
=======================================
  Files         604      604           
  Lines       34656    34656           
  Branches     5614     5597   -17     
=======================================
  Hits        28392    28392           
- Misses       5426     5438   +12     
+ Partials      838      826   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label May 22, 2025
Copy link
Collaborator

@josephmyers josephmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Nateowami)

@josephmyers josephmyers self-assigned this May 26, 2025
@josephmyers josephmyers added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels May 26, 2025
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels May 28, 2025
@Nateowami Nateowami force-pushed the feature/SF-3331b-simplify-multi-select-css branch from a6322c8 to 82e63c8 Compare May 28, 2025 15:17
@Nateowami Nateowami enabled auto-merge (squash) May 28, 2025 15:17
@Nateowami Nateowami merged commit 90749b0 into master May 28, 2025
16 checks passed
@Nateowami Nateowami deleted the feature/SF-3331b-simplify-multi-select-css branch May 28, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing complete Testing of PR is complete and should no longer hold up merging of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants