Skip to content

Remove obsolete source quote convention #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pmachapman wants to merge 1 commit into from
Closed

Remove obsolete source quote convention #3607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/SIL.XForge.Scripture/Services/MachineApiService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2288,9 +2288,7 @@ .. translationBuild
QuotationDenormalization =
parallelCorpusId is not null
&& translationBuild.Analysis?.FirstOrDefault(a =>
a.ParallelCorpusRef == parallelCorpusId
&& !string.IsNullOrEmpty(a.SourceQuoteConvention)
&& !string.IsNullOrEmpty(a.TargetQuoteConvention)
a.ParallelCorpusRef == parallelCorpusId && a.CanDenormalizeQuotes
)
is not null
? QuotationAnalysis.Successful
Expand Down
4 changes: 2 additions & 2 deletions test/SIL.XForge.Scripture.Tests/Services/MachineApiServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,7 +987,7 @@ public async Task GetBuildAsync_IncludesAdditionalInfo()
new ParallelCorpusAnalysis
{
ParallelCorpusRef = parallelCorpusId1,
SourceQuoteConvention = "standard_english",
CanDenormalizeQuotes = true,
TargetQuoteConvention = "standard_english",
},
],
Expand Down Expand Up @@ -1272,7 +1272,7 @@ public async Task GetBuildsAsync_SuccessWithEventMetrics()
new ParallelCorpusAnalysis
{
ParallelCorpusRef = ParallelCorpusId01,
SourceQuoteConvention = "standard_english",
CanDenormalizeQuotes = true,
TargetQuoteConvention = "standard_english",
},
];
Expand Down
Loading