SF-3651 Allow serval admins to download training data

[RaymondLuong3]

Serval admins can look at the training data files that have been uploaded for a specific project and can download those files. This will help serval admins more quickly identify issues using training data.

---

This change is 

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.82%. Comparing base (45a667d) to head (6712bef).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../serval-administration/serval-project.component.ts	90.90%	1 Missing ⚠️
...ipture/ClientApp/src/xforge-common/file.service.ts	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3614   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         610      610           
  Lines       37420    37438   +18     
  Branches     6132     6160   +28     
=======================================
+ Hits        30992    31008   +16     
+ Misses       5494     5482   -12     
- Partials      934      948   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pmachapman]

Looks good - just one comment when a training data file was originally uploaded from an Excel file

@pmachapman reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaymondLuong3)

---

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-project.component.ts line 338 at r1 (raw file):

    if (trainingData == null) return this.noticeService.show('File not found');

    this.fileService.onlineDownloadFile(FileType.TrainingData, trainingData.fileUrl, trainingData.title);

title is the original filename that was uploaded and wont end in .csv. All data is stored as CSV on our server (we do not store the original XLS or XLSX files if the user uploads an Excel file). Can you please have this set the file extension to ".csv" if the mimeType is text/csv?

Code quote:

this.fileService.onlineDownloadFile(FileType.TrainingData, trainingData.fileUrl, trainingData.title);

[RaymondLuong3]

@RaymondLuong3 made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @pmachapman).

---

src/SIL.XForge.Scripture/ClientApp/src/app/serval-administration/serval-project.component.ts line 338 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

title is the original filename that was uploaded and wont end in .csv. All data is stored as CSV on our server (we do not store the original XLS or XLSX files if the user uploads an Excel file). Can you please have this set the file extension to ".csv" if the mimeType is text/csv?

Thanks for the suggestion. I put the logic into fileService.ts since it might be useful for the auto-detection of the mime type. Let me know if that makes sense?

[pmachapman]

@pmachapman reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RaymondLuong3).

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/file.service.ts line 230 at r2 (raw file):

          // use the .csv extension explicitly if the MIME type is csv
          filename = filename.split('.')[0] + '.csv';
        }

This will return incorrect filenames for filenames like "test.data.xlsx". Something like this might be better?

if (blob.type === 'text/csv') {
  const extensionIndex: number = filename.lastIndexOf('.');
  filename = (extensionIndex !== -1 ? filename.substring(0, extensionIndex) : filename) + '.csv';
}

Code quote:

        if (blob.type === 'text/csv') {
          // use the .csv extension explicitly if the MIME type is csv
          filename = filename.split('.')[0] + '.csv';
        }

[RaymondLuong3]

@RaymondLuong3 made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @pmachapman).

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/file.service.ts line 230 at r2 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

This will return incorrect filenames for filenames like "test.data.xlsx". Something like this might be better?

if (blob.type === 'text/csv') {
  const extensionIndex: number = filename.lastIndexOf('.');
  filename = (extensionIndex !== -1 ? filename.substring(0, extensionIndex) : filename) + '.csv';
}

You are right. How does this look?

[pmachapman]

@pmachapman reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3).

[pmachapman]

@pmachapman reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3).