Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collection in config.yaml #106

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

woojae-siloai
Copy link
Contributor

@woojae-siloai woojae-siloai commented Feb 19, 2025

I guess this will help this ticket to bundle related tools.

Specify three sets of cluster tools for monitoring, so that cluster forge users can easily setup the monitoring they need

minimal, collecting logs, showing gps are active, not storing anything
external 1 + push to an external service, whatever customer X happens to have
third 1 + push to our internal ops cluster

@punasusi just want to get a quick review before open PR

@punasusi
Copy link
Contributor

Yes, this looks good! Then we can add collections and still manage the individual components as separate objects. The theory here looks correct, and would fulfill the desired uses :) Great!

@woojae-siloai
Copy link
Contributor Author

@punasusi FYI

I ran "smelt" and selected "all" at both of "main" and "add-collection-config-yaml" branches with/without devbox. I ran "just clean-all" every time.

I found that only selected "all" with devbox gave all the tools. I cannot get all the tools without devbox.

@woojae-siloai woojae-siloai marked this pull request as ready for review February 19, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants