finite vs isfinite in myGriddata.m

[sheremat]

Hi all,

I found an issue when trying to paint onto the flat patch from the grey. Specifically, there is a line that checks that the values are finite. Previously matlab used the function finite, but now it has been updated to the function isfinite. This may be different for different versions of matlab. What I am doing is to use try ... finite, catch me ...isfinite so myGriddata.m will work on all versions. I have confirmed this error and its fix on my setup and it works.

If this sounds like a good option (i.e. if I don't hear any complaints by end of business today) I will try merging this change and practice using the git stream. It seems like a small, simple fix that will not harm anyone and will help some, and will be a good test of using the git setup. My main question would be, where would we want the new version of myGriddata.m to be? I could put it in silverlab_vista_tools if people are putting that folder higher in the path than vistasoft. Alternatively, I could change the original file.

Summer

[racheldenison]

Hi Summer,

I think your improved version of myGriddata.m is exactly the kind of thing
that should go in the "mrvista_development" folder, which everyone should
have higher on their path than vistasoft.

I think we decided that we should not change any files in vistasoft,
since this serves as our record of our original installation.

Cheers,

Rachel

On Fri, Dec 9, 2011 at 7:40 AM, sheremat <
reply@reply.github.com

wrote:

Hi all,

I found an issue when trying to paint onto the flat patch from the grey.
Specifically, there is a line that checks that the values are finite.
Previously matlab used the function finite, but now it has been updated to
the function isfinite. This may be different for different versions of
matlab. What I am doing is to use try ... finite, catch me ...isfinite so
myGriddata.m will work on all versions. I have confirmed this error and its
fix on my setup and it works.

If this sounds like a good option (i.e. if I don't hear any complaints by
end of business today) I will try merging this change and practice using
the git stream. It seems like a small, simple fix that will not harm anyone
and will help some, and will be a good test of using the git setup. My main
question would be, where would we want the new version of myGriddata.m to
be? I could put it in silverlab_vista_tools if people are putting that
folder higher in the path than vistasoft. Alternatively, I could change the
original file.

Summer

---

Reply to this email directly or view it on GitHub:
#9