Github Actions for PHPUnit Tests #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverstripe/omnipay dev-master required for test folder
Removed guzzle/plugin-mock. The code is not used.
setUp function
Assert Matches Regular Expression
Replaced method fieldByName with dataFieldByName
Added dummy email address
Upgraded class to match the PaymentTest in silverstripe-omnipay: - added GuzzleHttp\Handler\MockHandler variable - updated methods getHttpClient, getHttpRequest & setMockHttpResponse
Added $this->expectException & $this->expectExceptionMessage methods Removed $this->fail method
For incomplete tests
Wrapped testsuite in testsuites
Added phpunit/phpunit & squizlabs/php_codesniffer to composer_require_extra in ci.yml to ensure that they are loaded Added php-http/discovery to ci.yml to ensure PSR-17 response factory is found in 7.4 prf-low mysql57 tests Migrated phpunit.xml.dist Copied phpcs.xml.dist over from silverstripe/framework Added protected variable $usesTransactions to OrderModifierTests & OrderProcessorTest Extended password length in OrderProcessorTest Added missing dependency php-http/guzzle7-adapter to composer.json (as per silverstripe-omnipay) Upgraded versions of omnipay/dummy & omnipay/paymentexpress to the latest (as per silverstripe-omnipay) & to dev-master for tests Set silverstripe/cms to v4.10 compatible with PHPUnit 9.5
Replaced strftime with date_format
Removed squizlabs/php_codesniffer from ci.yml
Code beautifier & fixer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded SilverShop's tests to PHPUnit 9.5. See issue #783.