Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run translations #234

Closed
github-actions bot opened this issue May 1, 2024 · 2 comments
Closed

Run translations #234

github-actions bot opened this issue May 1, 2024 · 2 comments
Assignees
@emteknetnz
Labels
affects/v5 impact/low type/i18n

Comments

@github-actions
Copy link

github-actions bot commented May 1, 2024 •
edited by GuySartorelli
Loading

This is an automatically created issue used to run translations every 3 months.

It was created by the .github/workflows/translation-issue.yml workflow in the silverstripe/.github repository.

Triage instructions (Silverstripe Ltd CMS Squad)

  1. Put on the following labels:
    • type/enhancement
    • impact/low
    • affects/v4
    • affects/v5
  2. Move this issue to the "Ready" column on our internal zenhub board

Implementation instructions:

  1. Create an install of kitchen-sink using the latest next-minor branch e.g. 5
  2. Also install silverstripe/tx-translator
  3. Follow the instructions in the tx-translator README.md and do a TX_PULL=0 TX_COLLECT=1 TX_PUSH=1 run.
  4. This may create lots of pull-requests. Paste links to these pull request on this issue.
  5. Once the pull-requests have been merged, create a new install of kitchen-sink using the oldest supported minor branch e.g. 4.13
  6. Also install silverstripe/tx-translator
  7. Follow the instructions in the tx-translator README.md and do a TX_PULL=1 TX_COLLECT=0 TX_PUSH=0 run.
  8. This will create lots of pull-requests. Paste links to these pull request on this issue.

Additional changes required

  • Update the CI action that creates this issue
    • remove the affects/v4 label.
    • update instruction for step 5 to use a CMS 5 branch as the example
    • Swap out type/enhancement for type/i18n

PRs - round 1

PRs - round 2
@GuySartorelli GuySartorelli self-assigned this May 6, 2024
This was referenced May 6, 2024
Merged
Merged
@GuySartorelli GuySartorelli removed their assignment May 6, 2024
@emteknetnz emteknetnz self-assigned this May 6, 2024
@emteknetnz
Copy link
Member

PRs merged, assigning back to Guy to continue from point 5

This was referenced May 6, 2024
Merged
Closed
@GuySartorelli
Copy link
Member

GuySartorelli commented May 7, 2024 •
edited
Loading

The PRs are pulling English into the non-English files again... will have to investigate to see what's going on.
Edit: Turns out we just forgot to tag it. 😮‍💨

@GuySartorelli GuySartorelli mentioned this issue May 7, 2024
Merged
@GuySartorelli GuySartorelli removed their assignment May 7, 2024
@GuySartorelli GuySartorelli mentioned this issue May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emteknetnz emteknetnz

Labels
affects/v5 impact/low type/i18n
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli