Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Skip null values #26

Merged
merged 1 commit into from
May 7, 2024
Merged

FIX Skip null values #26

merged 1 commit into from
May 7, 2024

Conversation

GuySartorelli
Copy link
Member

Avoids getting this error:

PHP Fatal error:  Uncaught TypeError: array_keys(): Argument #1 ($array) must be of type array, null given in /var/www/translations-pull/vendor/silverstripe/tx-translator/src/Translator.php:335

We can see we've done the same thing in the parent loop, too.

Issue

@GuySartorelli GuySartorelli mentioned this pull request May 6, 2024
Closed
@GuySartorelli GuySartorelli changed the base branch from 1 to 1.1 May 7, 2024 01:23
@emteknetnz emteknetnz merged commit 25f272f into silverstripe:1.1 May 7, 2024
1 check passed
@emteknetnz emteknetnz deleted the pulls/1.1/fix-null-issue branch May 7, 2024 02:57
@emteknetnz
Copy link
Member

Have tagged 1.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz