DOC Document breaking changes to template syntax #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
GuySartorelli
force-pushed
the
pulls/5/rescue-master-template-enhancements
branch
from
a0dbecf to
35ac578
Compare
emteknetnz
requested changes
Sep 13, 2022
en/04_Changelogs/5.0.0.md
Outdated
| You may need to do a search for `$Up.Up` in your templates to resolve situations where you have worked around this - with the example above, you would need to rewrite it to `$Up.Title` (removing the second `Up`). | ||
| - Numeric, boolean and null values passed to methods in templates will now preserve their type, rather than always being cast to strings. E.g. `$Foo(true)` would previously pass a string argument `'true'` to the `Foo()` method, but will now pass an actual boolean. | ||
|
|
||
| You may need to check for situations where you were working around this limitation, such as checking for `$param === 'false'` if you were passing `false` into some method from a template. |
There was a problem hiding this comment.
Suggested change
| You may need to check for situations where you were working around this limitation, such as checking for `$param === 'false'` if you were passing `false` into some method from a template. | |
| You may need to check for situations where you were working around this limitation, such as checking in php code for `$param === 'false'` if you were passing `false` into some method from a template. |
GuySartorelli
force-pushed
the
pulls/5/rescue-master-template-enhancements
branch
from
35ac578 to
8f89d86
Compare
GuySartorelli
force-pushed
the
pulls/5/rescue-master-template-enhancements
branch
from
8f89d86 to
0f9ec14
Compare
emteknetnz
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents the changes in silverstripe/silverstripe-framework#10497
Based on the original documentation changes in the PRs being rescued by that PR.
Parent issue