Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX allow single pipe for composer OR #109

Merged

Conversation

andrewandante
Copy link
Contributor

@andrewandante andrewandante commented Oct 8, 2024

Description

Allow old (but valid) composer OR syntax

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@GuySartorelli
Copy link
Member

CI is failing on your new test scenario, can you please take a look?

@andrewandante andrewandante force-pushed the FIX_support_old_composer_pipe branch from 99f1a42 to afc561d Compare October 9, 2024 22:53
@andrewandante
Copy link
Contributor Author

CI is failing on your new test scenario, can you please take a look?

Yep, fixed it up to replicate the same output as the || version above it, as it should behave the same way

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making this change.

@GuySartorelli GuySartorelli merged commit a9114cd into silverstripe:1 Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants