NEW Add sniffer code #1
Conversation
src/Sniffer.php
Outdated
| foreach ($todo as $block) { | ||
| if ($block->ignored === false) { | ||
| $currDir = dirname($block->realPath); | ||
| if ($lastDir !== $currDir) { | ||
| if (PHP_CODESNIFFER_VERBOSITY > 0) { | ||
| echo 'Changing into directory ' . Common::stripBasepath($currDir, $sniffer->config->basepath) . PHP_EOL; | ||
| } | ||
|
|
||
| $lastDir = $currDir; | ||
| } | ||
|
|
||
| $sniffer->processFile($block); | ||
| } else if (PHP_CODESNIFFER_VERBOSITY > 0) { | ||
| echo 'Skipping ' . basename($block->path) . PHP_EOL; | ||
| } | ||
|
|
||
| $numProcessed++; | ||
| $sniffer->printProgress($block, $numBlocks, $numProcessed); | ||
| } |
There was a problem hiding this comment.
For this method, everything outside this loop is copied directly from Runner::run(), so we probably don't want to change much of that.
GuySartorelli
force-pushed
the
pulls/1/new-repo
branch
4 times, most recently
from
61ab06c to
58b240b
Compare
GuySartorelli
force-pushed
the
pulls/1/new-repo
branch
from
58b240b to
cb5a657
Compare
| For some reason this one doesn't get auto-fixed. | ||
|
|
||
| - this one will be indented | ||
| ```php | ||
| class FinalClass { | ||
| private string $lastProperty='this is the value'; | ||
| } | ||
| ``` | ||
| - And it'll also have linting failures |
There was a problem hiding this comment.
The note about this one not getting auto-fixed is obviously pointing out a bug.
Once this PR is merged I'll raise a new issue about it, but I couldn't see an obvious way to resolve it. I figured it was better to have this working in the 90% of scenarios that it needs to for now, and we can fix that later on.
It does get correctly linted (there's another test validating that), so we will be able to fix those linting failures manually in the meantime.
As discussed in person, I've pointed the main blocks of these out with PR comments, plus the There are other bits here-and-there but not in such easily identifiable chunks. |
GuySartorelli
force-pushed
the
pulls/1/new-repo
branch
from
1e5c514 to
dc76ab9
Compare
NOTES
Issue