Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift code into app/src #11

Merged
merged 2 commits into from
Apr 11, 2018
Merged

Shift code into app/src #11

merged 2 commits into from
Apr 11, 2018

Conversation

tractorcow
Copy link

Shift code into app/src
14da371 
Add autoloading bootstrapping
@chillu chillu mentioned this pull request Apr 5, 2018
Closed
6 tasks
@kinglozzer
Copy link
Member

Why the outer namespace {?

@tractorcow
Copy link
Author

tractorcow commented Apr 5, 2018 •
edited
Loading

Makes "no namespace" linting errors go away. One fewer phpcs rule exemption to PSR2 we can have.

@tractorcow
Copy link
Author

Merging post internal review. We can adjust the namespace {} later if we need to.

@tractorcow tractorcow merged commit 5a8f201 into silverstripe:1 Apr 11, 2018
@tractorcow tractorcow deleted the pulls/1/appy-days branch April 11, 2018 03:24
@maxime-rainville maxime-rainville mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclecheese unclecheese unclecheese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tractorcow @kinglozzer @unclecheese