Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or correctly implement commented-out unit tests #1601

Open
sabina-talipova opened this issue Oct 17, 2023 · 2 comments
Open

Remove or correctly implement commented-out unit tests #1601

sabina-talipova opened this issue Oct 17, 2023 · 2 comments
Labels
affects/v5 type/enhancement

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Oct 17, 2023 •
edited
Loading

Description

PHP Unit tests SecurityAdminTest::testGroupExport and SecurityAdminTest::testEmptyGroupExport are commented out.
Investigate what they test and do we still need them. If they are no longer required, then we should remove them.
This was referenced Oct 17, 2023
Closed
Merged
@GuySartorelli
Copy link
Member

@sabina-talipova Can you please provide more details here? It's not clear what is meant by this.

@sabina-talipova
Copy link
Contributor Author

I've updated this ticket.

@GuySartorelli GuySartorelli changed the title TODO: Update SecurityAdminTest::testGroupExport and SecurityAdminTest::testEmptyGroupExport Remove or correctly implement commented-out unit tests Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v5 type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GuySartorelli @sabina-talipova