MNT Remove TODO comments #1608
Merged
MNT Remove TODO comments #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
commented
Oct 17, 2023
sabina-talipova
commented
Oct 17, 2023
| @@ -8,7 +8,6 @@ | |||
| letter-spacing: .3px; | |||
| } | |||
|
|
|||
| // Todo: replace .status-archived class name with .badge--[modifier] | |||
There was a problem hiding this comment.
Open ticket: #1595
sabina-talipova
commented
Oct 17, 2023
There was a problem hiding this comment.
Open ticket: #1595
sabina-talipova
commented
Oct 17, 2023
There was a problem hiding this comment.
Open ticket: #1595
sabina-talipova
commented
Oct 17, 2023
| @@ -73,7 +73,6 @@ class FormAlert extends Component { | |||
| } | |||
|
|
|||
| render() { | |||
| // @todo default this.props.visible as null | |||
There was a problem hiding this comment.
Open ticket: #1595
sabina-talipova
commented
Oct 17, 2023
| @@ -241,7 +241,6 @@ class FormBuilder extends Component { | |||
| return formSchema; | |||
| }) | |||
| .catch((reason) => { | |||
| // @todo Generic CMS error reporting | |||
There was a problem hiding this comment.
Open ticket: #1595
sabina-talipova
commented
Oct 17, 2023
There was a problem hiding this comment.
Open ticket: #1596
sabina-talipova
commented
Oct 17, 2023
There was a problem hiding this comment.
Open ticket: #1595
sabina-talipova
commented
Oct 17, 2023
There was a problem hiding this comment.
opent ticket: #1597
sabina-talipova
commented
Oct 17, 2023
There was a problem hiding this comment.
Open ticket: #1602
sabina-talipova
commented
Oct 17, 2023
sabina-talipova
commented
Oct 17, 2023
There was a problem hiding this comment.
Open ticket: #1598
sabina-talipova
commented
Oct 17, 2023
There was a problem hiding this comment.
Open ticket: #1606
sabina-talipova
commented
Oct 17, 2023
client/src/legacy/LeftAndMain.js
Outdated
There was a problem hiding this comment.
Open ticket: #1603
sabina-talipova
commented
Oct 17, 2023
| @@ -41,7 +41,6 @@ import debounce from 'lodash.debounce'; | |||
| * ignoreFieldSelector: jQuery selector string for specifically excluded fields | |||
| * changedCssClass: CSS class attribute which is appended to all changed fields and the form itself | |||
| * | |||
| * @todo Implement form reset handling | |||
There was a problem hiding this comment.
It looks like reset has been implemented
sabina-talipova
commented
Oct 17, 2023
| @@ -147,7 +147,6 @@ class TinyMCEActionRegistrar { | |||
| } | |||
| } | |||
|
|
|||
| // TODO Fix registration across modules, see lib/Router.js for details | |||
There was a problem hiding this comment.
Open ticket: #1605
sabina-talipova
commented
Oct 17, 2023
client/src/lib/Router.js
Outdated
| @@ -116,7 +116,7 @@ page.routeAppliesToCurrentLocation = routeAppliesToCurrentLocation; | |||
| * the copy of `router` in `framework` is not the same copy of `router` | |||
| * available in `custom`. | |||
| * | |||
| * @TODO Look into SystemJS as a solution https://github.com/systemjs/systemjs | |||
| * @link Look into SystemJS as a solution https://github.com/systemjs/systemjs | |||
There was a problem hiding this comment.
Open ticket: #1605
sabina-talipova
commented
Oct 17, 2023
client/src/lib/ReactRouteRegister.js
Outdated
| @@ -170,7 +170,7 @@ class ReactRouteRegister { | |||
| * `reactRouteRegister`, the copy of `reactRouteRegister` in `framework` is not | |||
| * the same copy of `reactRouteRegister` available in `custom`. | |||
| * | |||
| * @TODO Look into SystemJS as a solution https://github.com/systemjs/systemjs | |||
| * @link Look into SystemJS as a solution https://github.com/systemjs/systemjs | |||
There was a problem hiding this comment.
Open ticket: #1605
sabina-talipova
commented
Oct 17, 2023
| @@ -33,7 +33,6 @@ const buildApolloGraphqlContainer = ( | |||
| /* eslint-disable max-len, no-unused-vars */ | |||
| scaffold(key, config, { force }) { | |||
| /* | |||
| * @todo build out scaffolding | |||
There was a problem hiding this comment.
Open ticket: #1604
sabina-talipova
commented
Oct 17, 2023
| @@ -19,8 +18,6 @@ body { | |||
| display: flex; | |||
| } | |||
|
|
|||
|
|
|||
| // TODO move out of layout | |||
There was a problem hiding this comment.
Open ticket: #1595
sabina-talipova
commented
Oct 17, 2023
| @@ -312,7 +310,6 @@ | |||
| white-space: nowrap; | |||
| } | |||
|
|
|||
| // TODO create pagination component | |||
There was a problem hiding this comment.
Open ticket: #1595
sabina-talipova
commented
Oct 17, 2023
| @@ -70,8 +70,6 @@ public static function populate_menu() | |||
| * Add a LeftAndMain controller to the CMS menu. | |||
| * | |||
| * @param string $controllerClass The class name of the controller | |||
| * @todo A director rule is added when a controller link is added, but it won't be removed | |||
| * when the item is removed. Functionality needed in {@link Director}. | |||
There was a problem hiding this comment.
Open ticket: #1599
sabina-talipova
commented
Oct 17, 2023
| @@ -65,6 +65,3 @@ Feature: Manage my own settings | |||
| And I select "German (Germany)" from "Interface Language" | |||
| And I press the "Save" button | |||
| Then I should see "Sprache" | |||
|
|
|||
| # TODO Date/time format - Difficult because its not exposed anywhere in the CMS? | |||
| # TODO Group modification as ADMIN user | |||
There was a problem hiding this comment.
Open ticket: #1600
sabina-talipova
commented
Oct 17, 2023
tests/php/SecurityAdminTest.php
Outdated
There was a problem hiding this comment.
Open ticket: #1601
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
2 times, most recently
from
cd65291 to
d3b0176
Compare
GuySartorelli
requested changes
Oct 25, 2023
client/src/lib/dependency-injection/buildApolloGraphqlContainer.js
Outdated
Show resolved
Hide resolved
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
2 times, most recently
from
28f2807 to
9a858d6
Compare
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
2 times, most recently
from
d95209f to
630be4e
Compare
GuySartorelli
requested changes
Oct 29, 2023
sabina-talipova
force-pushed
the
pulls/2.1/remove-todo
branch
from
630be4e to
c3bcf0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue