Prev, Next and Create buttons on detail GridField forms

[chillu]

Overview

It's often cumbersome to move through a list of items by clicking into the detail view, hitting the "back" button, and clicking into the next item. The betterbuttons module solved this for 3.x, and there's a good case for making it a core feature. @sachajudd and @clarkepaul have designed a solution as part of a Save and add new button design.

Acceptance Criteria

• I can add a new record from a record detail form
• If choosing to add a new record or navigate to the previous/next record on a record detail form with unsaved edits, I get a prompt and stay on the same screen until I've saved the record explicitly.
• I can navigate to the previous and next records of a list when viewing a record detail form
• If there is no more previous or next records, the button is disabled
• The new buttons don't compromise more important buttons on small screens
• The functionality works in ModelAdmin and any other GridField
• Sorting and filtering is retained
• Does not double up when betterbuttons is installed (might need a patch to that module?) (UPDATE: BetterButtons already takes priority and overrides all the actions)
• Should work in default configurations, but can be opted out of
• Behat Tests written
• Update documentation
• Excludes choosing the type of record to create (that's a thing in some GridField modules)
• Excludes any "save and close" or "publish and close" logic

Designs

Styleguide

Notes

• Some historical context and discussion in a duplicate card

Pull Requests

• Port betterbuttons to framework silverstripe-framework#8569
• Add tests and styling for betterbuttons port #744
• Use new plus icon silverstripe-framework#8619

[bummzack]

Yes, this would be an awesome addition!

Please also consider the case where different classes can be added to a relation. Meaning that the "add new" button should turn into a flyout where you can select the class to create (the gridfield equivalent of this is the GridFieldAddNewMultiClass component added via gridfieldextensions). The elemental-module makes use of this to add the different block-types to a page.

It doesn't have to be in core, but it should be possible to add this via extensions or similar.

[Rhym]

4.1.1 here we gooooo!

[chillu]

Separated out one AC to #486

[chillu]

@sachajudd commented on the duplicate card:

We should have a warning indicating to the user that they have unsaved changes before they navigate away. We thought the "save/publish and create new" action was better suited in the drop-down area.

I've changed the AC accordingly. So the "plus" button would only create a new record, not also save the existing one.

[patricknelson]

Excludes any "save and close" or "publish and close" logic

So, I think this means that the extra imputed functionality necessary for maintaining Version'ed DataObject's managed in GridField instances will still reside entirely in the betterbuttons module, is this correct? That is, the special BetterButton_SaveDraft and BetterButton_Publish buttons incorporated by the module right now ("Saved" and "Save & publish") and the associated "stage" level DB persistence abstraction interfacing with the Versioned:: API.

If that's not the case, could someone point me in the direction where this will eventually live long term for SS 4+ and onward (if not in betterbuttons module or in silverstripe-admin)?

[bergice]

@patricknelson that's correct. This is only porting the Previous, Next and Add buttons on the edit form.

[unclecheese]

@patricknelson It's an MVP at this point. We need to satisfy the squeakiest wheel, and that's prev/next and add. That's most of the reason why users are installing betterbuttons. Further down the track, I see this API expanding to support additional prebaked and custom actions, and may even do so in 4.4, as this PR isn't going to make it into 4.3 anyway.

[Rhym]

@unclecheese I'll give you $5 if it goes into 4.3. rubs hands

[normann]

Just wondering when this bit can be released to a stable?

[chillu]

It's already in the latest 4.x stable

[Rhym]

@chillu As in the current stable release? How would we activate/view this?

[chillu]

Can't recall, but I've just checked and it's in the admin/security section. The intent was that you don't need to configure this stuff, maybe the implementation has forgotten about this?

[ScopeyNZ]

It will be released in 4.4. Not yet tagged.

[Rhym]

@ScopeyNZ Do we have a rough estimate for 4.4? this button would help a lot with a client's data entry.

[ScopeyNZ]

4.4 should be within the next couple of months. I think there's a tentative schedule to have an RC on the week beginning 6th of May.

[Rhym]

Excellent, looking forward to this addition :)

[Rhym]

It may have taken half a decade, but it's finally here! I used the buttons today, and they made me very happy. Thanks for all your work, team! 🎉🎉🎉

[ssimo3lsuhsc]

Where do I leave a comment to say that it doesn't work the way it should? Sometimes the Next button is greyed out on a non-final record, and sometimes the Previous button is inactive on a non-first record. I should add that the affected records are ALMOST NEVER page-initial or page-final in the current page of the query.

[andreaslindahl]

I have the same problem. The buttons are often disabled, when they shouldn't be.

[ScopeyNZ]

Please feel free to raise an issue with the problem. Preferably with some accurate steps to reproduce.

[chillu]

Note that I don't think prev/next takes filtered/ordered GridFields into account - @unclecheese you're working on persisting search parameters in the GridField URL state, do you think this might be overlapping?

[unclecheese]

My guess is that the issue here is non-deterministic sort. Make sure your dataobject has a default_sort defined, or explicitly sort the datalist you’re passing to the grid.

The fact that it happens unpredictably is a good indication that your result set isn’t predictable itself.

[ssimo3lsuhsc]

I have set a default_sort on my DataObject. The problem still occurs. It does not occur predictably with any given record, but it occurs in one of every five GridFieldDetailForm views I make.

[unclecheese]

It’s exactly one out of every five?

So the steps to reproduce are:

• Edit record
• Go back to grid
• Repeat five times
• On the fifth time, the prev/next buttons are incorrect

[ssimo3lsuhsc]

It just seems like one of every five. I'm not sure even which records and steps are producing it anymore. From: Aaron Carlino <notifications@github.com> Sent: Tuesday, August 27, 2019 2:31 PM To: silverstripe/silverstripe-admin <silverstripe-admin@noreply.github.com> Cc: Simon, Stuart A. <ssimo3@lsuhsc.edu>; Comment <comment@noreply.github.com> Subject: Re: [silverstripe/silverstripe-admin] Prev, Next and Create buttons on detail GridField forms (#436) *EXTERNAL EMAIL: EVALUATE* It’s exactly one out of every five? So the steps to reproduce are: * Edit record * Go back to grid * Repeat five times * On the fifth time, the prev/next buttons are incorrect — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsilverstripe%2Fsilverstripe-admin%2Fissues%2F436%3Femail_source%3Dnotifications%26email_token%3DAE2FQOD37TAHUAMJGALRFJDQGV6GVA5CNFSM4EQ5QCKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5I3Q3A%23issuecomment-525449324&data=02%7C01%7Cssimo3%40lsuhsc.edu%7Cdd2a557f92464f6932e008d72b251266%7C3406368982d44e89a3281ab79cc58d9d%7C0%7C0%7C637025310530383441&sdata=qsVwjOsp%2FTFjh%2F%2Bnq1BbwMJ9skNuBhEmnDPVRa92k%2F8%3D&reserved=0>, or mute the thread<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE2FQOEULPGFAZDTKY26TK3QGV6GVANCNFSM4EQ5QCKA&data=02%7C01%7Cssimo3%40lsuhsc.edu%7Cdd2a557f92464f6932e008d72b251266%7C3406368982d44e89a3281ab79cc58d9d%7C0%7C0%7C637025310530393437&sdata=XXi1QpkJ7oSvNfZyF3JQ0sBLE7Bw6h%2BEm2ZdxBYX%2FHU%3D&reserved=0>.

[ssimo3lsuhsc]

It may be several problems masquerading as one. One possibly related problem is that when a new record is created, the buttons appear as though the record is at the beginning of the set. To test that this particular behavior is deterministic, I created a record with a page_number of 100 (my default_sort is page_number ASC). The number 100 is much higher than any number I had previously put in that field. So the record should have been at the end when the default_sort was applied. Yet the buttons show it is still at the beginning. From: Aaron Carlino <notifications@github.com> Sent: Tuesday, August 27, 2019 2:31 PM To: silverstripe/silverstripe-admin <silverstripe-admin@noreply.github.com> Cc: Simon, Stuart A. <ssimo3@lsuhsc.edu>; Comment <comment@noreply.github.com> Subject: Re: [silverstripe/silverstripe-admin] Prev, Next and Create buttons on detail GridField forms (#436) *EXTERNAL EMAIL: EVALUATE* It’s exactly one out of every five? So the steps to reproduce are: * Edit record * Go back to grid * Repeat five times * On the fifth time, the prev/next buttons are incorrect — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsilverstripe%2Fsilverstripe-admin%2Fissues%2F436%3Femail_source%3Dnotifications%26email_token%3DAE2FQOD37TAHUAMJGALRFJDQGV6GVA5CNFSM4EQ5QCKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5I3Q3A%23issuecomment-525449324&data=02%7C01%7Cssimo3%40lsuhsc.edu%7Cdd2a557f92464f6932e008d72b251266%7C3406368982d44e89a3281ab79cc58d9d%7C0%7C0%7C637025310530383441&sdata=qsVwjOsp%2FTFjh%2F%2Bnq1BbwMJ9skNuBhEmnDPVRa92k%2F8%3D&reserved=0>, or mute the thread<https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE2FQOEULPGFAZDTKY26TK3QGV6GVANCNFSM4EQ5QCKA&data=02%7C01%7Cssimo3%40lsuhsc.edu%7Cdd2a557f92464f6932e008d72b251266%7C3406368982d44e89a3281ab79cc58d9d%7C0%7C0%7C637025310530393437&sdata=XXi1QpkJ7oSvNfZyF3JQ0sBLE7Bw6h%2BEm2ZdxBYX%2FHU%3D&reserved=0>.