Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Run yarn build #1462

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Conversation

GuySartorelli
Copy link
Member

Fixes https://github.com/silverstripe/silverstripe-admin/actions/runs/4298485530/jobs/7493203050

git diff found modified files when it should not have:
M js/bundle.js

Note that this seems to be a recurring issue where the local build is initially somehow unexplainably different than what CI gets - and after several attempts the local build magically gets the same changes CI sees. I've raised an issue for us to investigate that: silverstripe/gha-run-tests#11

Parent issue

@GuySartorelli GuySartorelli marked this pull request as ready for review March 1, 2023 01:13
@emteknetnz emteknetnz merged commit 6dff523 into silverstripe:1 Mar 2, 2023
@emteknetnz emteknetnz deleted the pulls/1/fix-js branch March 2, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants