Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Update Storybook logo to the 5.1 OSS logo #1594

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

edwilde
Copy link
Contributor

@edwilde edwilde commented Oct 12, 2023

I use the storybook pattern lib fairly often, the new OSS logo has rolled out across the rest of dotorg, but appears to have been missed here.

I am not sure how permanent the silverstripe.org url is for the logo, should it be included in this repo instead?

@edwilde edwilde changed the title Update Storybook logo to the 5.1 OSS logo FIX Update Storybook logo to the 5.1 OSS logo Oct 25, 2023
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for this. I'll let ci run and then merge.

@edwilde
Copy link
Contributor Author

edwilde commented Oct 27, 2023

Quick note for any other product storybook noobs out there.

When trying to build initially I got this error.

info Found existing addon "@storybook/addon-controls", skipping.
info Found existing addon "@storybook/addon-actions", skipping.
info Found existing addon "@storybook/addon-controls", skipping.
info Found existing addon "@storybook/addon-actions", skipping.
info => Starting manager..
SB_CORE-COMMON_0004: Storybook could not index your stories.
Your main configuration somehow does not contain a 'stories' field, or it resolved to an empty array.

Please check your main configuration file and make sure it exports a 'stories' field that is not an empty array.

More info: https://storybook.js.org/docs/react/faq#can-i-have-a-storybook-with-no-local-stories

    at normalizeStories (./node_modules/@storybook/core-common/dist/index.js:21:2214)
    at iframe_webpack_config_default (./node_modules/@storybook/builder-webpack5/dist/presets/preview-preset.js:3:1890)
    at async starter (./node_modules/@storybook/builder-webpack5/dist/index.js:1:4658)

To fix this I had to adjust the projectRoot in ./.storybook/lib/storyTeller.js (line 111) and remove /../../../.

I then got this error towards the end of the build process

ModuleNotFoundError: Module not found: Error: Can't resolve 'constants'

This was fixed by adding an empty json object to the root called ./constants.json

echo "{}" > constants.json

Hope this helps someone in the future 🚀

@edwilde
Copy link
Contributor Author

edwilde commented Oct 27, 2023

Thanks @GuySartorelli 👍

@GuySartorelli GuySartorelli merged commit c5f6a15 into silverstripe:2 Oct 27, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants