FIX Enable bypassing entwine onsubmit handler #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/2/bypass-entwine
branch
8 times, most recently
from
2db1365
to
6e6acce
Compare
emteknetnz
commented
Feb 27, 2024
| }; | ||
|
|
||
| Toast.defaultProps = { | ||
| actions: [] | ||
| actions: [], | ||
| onDismiss: () => {}, |
There was a problem hiding this comment.
This is to fix an unrelated console warning after running yarn dev
"Warning: Failed prop type: The prop toasts[0].onDismiss is marked as required in Toasts, but its value is undefined."
emteknetnz
force-pushed
the
pulls/2/bypass-entwine
branch
from
6e6acce
to
1e64bf5
Compare
GuySartorelli
requested changes
Mar 13, 2024
emteknetnz
force-pushed
the
pulls/2/bypass-entwine
branch
2 times, most recently
from
ed6e7d5
to
85cb4c2
Compare
This was referenced Mar 15, 2024
GuySartorelli
approved these changes
Mar 17, 2024
emteknetnz
force-pushed
the
pulls/2/bypass-entwine
branch
from
85cb4c2
to
ed5c451
Compare
maxime-rainville
force-pushed
the
pulls/2/bypass-entwine
branch
from
ed5c451
to
6413543
Compare
|
I've rebased the PR to solved the merge conflict and will merge on green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-elemental#329