FIX Correctly set img tag attributes for WYSIWYG #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2024
GuySartorelli
force-pushed
the
pulls/2.2/fix-wysiwyg-valid-elements
branch
from
49ed4c6
to
89a6923
Compare
|
behat failures are pre-existing - see https://github.com/silverstripe/silverstripe-admin/actions/runs/10123308730 |
emteknetnz
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same fix as silverstripe/cwp#340 but for the default "cms" WYSIWYG config.
Fixes https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/10102090864/job/27937027096 and https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/10102090864/job/27937027255 in tandem with silverstripe/silverstripe-cms#2978
In this case for some reason the behat test was explicitly expecting no alt tag, though it's clear that the empty alt tag should be displayed.
Issue