DEP Upgrade bootstrap and reactstrap #1537
Open
+495
−458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
GuySartorelli
force-pushed
the
pulls/3.0/upgrade-bootstrap
branch
4 times, most recently
from
e4c590d to
908ee0f
Compare
GuySartorelli
force-pushed
the
pulls/3.0/upgrade-bootstrap
branch
from
908ee0f to
06312a3
Compare
GuySartorelli
commented
Jan 23, 2025
There was a problem hiding this comment.
Removing react from the dependencies resulted in jest defaulting to "react latest" which caused some tests to fail.
| .arrow { | ||
| .popover-arrow { |
There was a problem hiding this comment.
https://getbootstrap.com/docs/5.0/migration/#popovers
Renamed
.arrowto.popover-arrowin our default popover template.
| onClick={this.props.onClosed} | ||
| aria-label={i18n._t('FormBuilderModal.CLOSE', 'Close')} | ||
| > | ||
| <span aria-hidden="true">×</span> |
There was a problem hiding this comment.
This x was being rendered on top of the existing styling for the modal close button, so there were two x being rendered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to remove
reactas a direct dependency because it got confused between the version being installed locally and the one included from admin, which resulted in false-negatives with errors saying "you can't use hooks" when they were in fact being used correctly.Update to eslint is because it defaulted to assuming the latest version of react which resulted in a lint error, because we're not using the latest version of react.
See silverstripe/silverstripe-admin#1889 which links to the specific upgrade guide entries for most changes made.
Issue