BUGFIX: Ensure list is limited appropriately before evaluating #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
unclecheese
force-pushed
the
pulls/1.3/connection-correction
branch
from
edc1621
to
e5273bb
Compare
3 tasks
|
I was just sharing the importance of appropriately limiting large datasets. :) |
|
Confirmed this works on a kitchen sink recipe (by checking counts on a large folder before and after) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a potential memory leak when large numbers of assets are in the database. The
get_by_stagecall should be limited according to the parameters of the query.Notes
This is not an ideal fix. The reliance on
$result['edges']is due to theresolveList()function returning a data structure that is only suitable for GraphQL. There is a separate PR for GraphQL that abstracts that out. That PR is not a dependency of this fixBecause the GraphQL PR is a new API, a separate PR will be made to asset-admin for the next minor release using the new GraphQL methodsIt's a pretty minor point, and probably not worth quibbling over.